RFR: 8310844: [AArch64] C1 compilation fails because monitor offset in OSR buffer is too large for immediate [v2]
Andrew Dinn
adinn at openjdk.org
Thu Jan 4 16:24:22 UTC 2024
On Thu, 4 Jan 2024 16:14:41 GMT, Andrew Dinn <adinn at openjdk.org> wrote:
>> Thanks for the review. I adjusted the fix accordingly.
>
> I'm not sure why the recommended adjustment is needed. The macro assembler does fuse pairs of adjacent ldr instructions into an ldp but only when the sizes match and the offsets fit into the requisite number of bits.
>
> So, if the two ldr instrctions ar egenerated next to each other the macroasembler should only convert to ldp *where appropriate*. Am I missing something here?
Doh, sorry - I misread Andrew's proposed code! Ignore the noise.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/17266#discussion_r1441978216
More information about the hotspot-compiler-dev
mailing list