RFR: 8320128: Clean up Parse constructor for OSR [v3]

Xin Liu xliu at openjdk.org
Thu Jan 4 17:06:45 UTC 2024


On Thu, 4 Jan 2024 08:48:59 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

>> Xin Liu has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision:
>> 
>>  - Use atomic logline and resume #ifdef ASSERT.
>>  - Merge branch 'master' into JDK-8320128
>>  - Update according to reviewer's feedback.
>>  - 8320128: Clean up Parse constructor for OSR
>
> src/hotspot/share/opto/parse1.cpp line 511:
> 
>> 509:       if (PrintOpto && (Verbose || WizardMode)) {
>> 510:         if (is_osr_parse()) {
>> 511:           tty->print("OSR @%d type flow bailout: %s", _entry_bci, _flow->failure_reason());
> 
> Should be `print_cr`.

Sorry, I would have discovered this by myself. 
updated!

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16669#discussion_r1442038930


More information about the hotspot-compiler-dev mailing list