RFR: 8320128: Clean up Parse constructor for OSR [v4]

[Aleksey Shipilev]

On Thu, 4 Jan 2024 20:10:56 GMT, Xin Liu <xliu at openjdk.org> wrote:

>> src/hotspot/share/opto/parse1.cpp line 414:
>> 
>>> 412:   if (PrintCompilation || PrintOpto) {
>>> 413:     // Make sure I have an inline tree, so I can print messages about it.
>>> 414:     InlineTree::find_subtree_from_root(C->ilt(), caller, parse_method);
>> 
>> Reading this again, you sure that we don't need `caller->caller()` on `is_osr_parse()` path?
>
> first of all, is_osr_parse() was false at line 415 because _entry_bci was assigned to InvocationEntryBci right before.  That's why I use *caller* directly. 
> 
> Even we consider to build InlineTree for OSR, I don't think caller->caller() is correct.
> I explain this in item 2 here.
> https://github.com/openjdk/jdk/pull/16669#issuecomment-1820258714

Ah OK, trippy... All good then.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16669#discussion_r1442211363