RFR: 8319793: C2 compilation fails with "Bad graph detected in build_loop_late" after JDK-8279888 [v9]

[Roland Westrelin]

On Thu, 4 Jan 2024 15:32:21 GMT, Emanuel Peter <epeter at openjdk.org> wrote:

> Generally, I'm not really happy with the name of `UnknownControl`. Sounds like the control is unknown. In what sense is it unknown, after all we have a control and want the Load to be pinned to it...?

`UnknownControl` was not added by this change.

> Maybe then we could rename `pin_for_array_access` -> `make_pinned`.

But `make_pinned` seems to imply that it operates on any node type when it only does something for a subset of nodes (those used for array accesses).

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16886#discussion_r1442649362