RFR: 8322816: RISC-V: Incorrect guarantee in patch_vtype [v2]

Kim Barrett kbarrett at openjdk.org
Mon Jan 8 01:05:39 UTC 2024


> Please review this change that fixes a test for a guarantee.  This also
> removes a -Wparentheses warning when those are enabled (which is how the
> problem was discovered).
> 
> The problem is that operator precedence groups the sub-expressions differently
> than intended. The fix is to override the operator precedence by adding
> parentheses to achieve the intended grouping.
> 
> Testing: Local (linux-x64) cross-build for linux-riscv with this change plus
> -Wparentheses enabled and other changes to allow that to work.
> 
> Requesting someone from the riscv porters to properly test this.

Kim Barrett has updated the pull request incrementally with one additional commit since the last revision:

  guarantee !vill

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/17215/files
  - new: https://git.openjdk.org/jdk/pull/17215/files/a3723801..ab335602

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=17215&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=17215&range=00-01

  Stats: 4 lines in 1 file changed: 0 ins; 2 del; 2 mod
  Patch: https://git.openjdk.org/jdk/pull/17215.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/17215/head:pull/17215

PR: https://git.openjdk.org/jdk/pull/17215


More information about the hotspot-compiler-dev mailing list