RFR: 8322759: Eliminate -Wparentheses warnings in compiler code [v2]

[Kim Barrett]

On Wed, 3 Jan 2024 12:07:10 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

>> Kim Barrett has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision:
>> 
>>  - Merge branch 'master' into compiler-wparentheses
>>  - simplify asserts
>>  - update copyrights for new year
>>  - fix -Wparentheses warnings in non-C2 compiler code
>
> src/hotspot/share/compiler/compilerDefinitions.inline.hpp line 60:
> 
>> 58: 
>> 59: inline bool CompilerConfig::is_c1_or_interpreter_only_no_jvmci() {
>> 60:   assert((is_jvmci_compiler() && is_jvmci()) || !is_jvmci_compiler(), "JVMCI compiler implies enabled JVMCI");
> 
> This looks like simply:
> 
> 
> assert(!is_jvmci_compiler() || is_jvmci(), "JVMCI compiler implies enabled JVMCI");

Agreed.  Changed accordingly.

> src/hotspot/share/compiler/compilerDefinitions.inline.hpp line 117:
> 
>> 115: // Tiered is basically C1 & (C2 | JVMCI) minus all the odd cases with restrictions.
>> 116: inline bool CompilerConfig::is_tiered() {
>> 117:   assert((is_c1_simple_only() && is_c1_only()) || !is_c1_simple_only(), "c1 simple mode must imply c1-only mode");
> 
> Ditto, 
> 
> 
> assert(!is_c1_simple_only() || is_c1_only(), "c1 simple mode must imply c1-only mode");

Agreed.  Changed accordingly.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17200#discussion_r1444184964
PR Review Comment: https://git.openjdk.org/jdk/pull/17200#discussion_r1444185000