RFR: 8320128: Clean up Parse constructor for OSR [v4]
Tobias Hartmann
thartmann at openjdk.org
Mon Jan 8 06:55:24 UTC 2024
On Thu, 4 Jan 2024 17:06:38 GMT, Xin Liu <xliu at openjdk.org> wrote:
>> There's a special case for the constructor of Parse. If current compilation is OSR and it is handling the top-level method(depth() == 1), then
>>
>> 1. _tf = C->tf();
>> 2. _entry_bci = C->entry_bci();
>> 3. _flow = method()->get_osr_flow_analysis(_entry_bci);
>>
>> We don't need to assign those member data twice. We can also factor out _flow->failing() for the special case and normal cases.
>>
>> It's worth mentioning that we can't save ciTypeFlow computation because
>> get_osr_flow_analysis(_entry_bci) actually needs get_flow_analysis(method()).
>
> Xin Liu has updated the pull request incrementally with one additional commit since the last revision:
>
> Use print_cr for the log message.
All tests passed.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/16669#issuecomment-1880464791
More information about the hotspot-compiler-dev
mailing list