RFR: 8323115: x86-32: Incorrect predicates for cmov instruct transforms with UseSSE

[Tobias Hartmann]

On Mon, 8 Jan 2024 07:55:21 GMT, Kim Barrett <kbarrett at openjdk.org> wrote:

> Please review this change that fixes generation of CMOV by C2 as controlled by
> UseSSE.  The predicates controlling that generation were using implicit
> operator precedence that didn't have the expected grouping.  Fixed by adding
> parentheses to make the desired grouping explicit.
> 
> Testing: Ran GHA with -Wparentheses enabled along with this and other changes
> needed to make that work.

The fix looks good to me but it's concerning that we never hit this in testing. Maybe it never fails because the expanded instructions are guarded by `predicate (UseSSE ...` as well.

-------------

Marked as reviewed by thartmann (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/17296#pullrequestreview-1808685025