RFR: 8310190: C2 SuperWord: AlignVector is broken, generates misaligned packs [v59]

[Emanuel Peter]

On Mon, 8 Jan 2024 13:19:23 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:

>> Emanuel Peter has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   some minor changes for Vladimir
>
> src/hotspot/share/opto/superword.cpp line 1620:
> 
>> 1618: 
>> 1619:   const MemNode* mem_ref = pack->at(0)->as_Mem();
>> 1620:   VPointer mem_ref_p(mem_ref, phase(), lpt(), nullptr, false);
> 
> Since you renamed `p` -> `pack`, you should also rename this one to pack:
> Suggestion:
> 
>   VPointer mem_ref_pack(mem_ref, phase(), lpt(), nullptr, false);

I keep it without your suggestion.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14785#discussion_r1444766758