RFR: 8322982: CTW fails to build after 8308753 [v3]

Xin Liu xliu at openjdk.org
Mon Jan 8 20:08:37 UTC 2024


> This patch fixes the build error of CTW by sidelining ModuleInfoWriter.java. ModuleInfoWriter uses Class-File API, which has transitioned to preview.
> If we really need to compile it, we have to append --enable-preview and --source N. 
> 
> The fact is CTW itself doesn't depend on ModuleInfoWriter. I think it's easier to maintain CTW if we filter it out in Makefile.

Xin Liu has updated the pull request incrementally with one additional commit since the last revision:

  Wording and also remove add-modules required by ModuleInfoWriter.java

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/17292/files
  - new: https://git.openjdk.org/jdk/pull/17292/files/5ac1d9f1..7978052e

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=17292&range=02
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=17292&range=01-02

  Stats: 5 lines in 1 file changed: 0 ins; 4 del; 1 mod
  Patch: https://git.openjdk.org/jdk/pull/17292.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/17292/head:pull/17292

PR: https://git.openjdk.org/jdk/pull/17292


More information about the hotspot-compiler-dev mailing list