RFR: 8322589: Add Ideal transformation: (~a) & (~b) => ~(a | b) [v10]
Emanuel Peter
epeter at openjdk.org
Tue Jan 9 14:01:28 UTC 2024
On Tue, 9 Jan 2024 05:54:39 GMT, Zhiqiang Zang <duke at openjdk.org> wrote:
>> Hello,
>>
>> `(~a) & (~b) => ~(a | b)` is a widely seen pattern, for example it is implemented for LLVM [here](https://github.com/llvm/llvm-project/blob/397f1ce9efb4eea1ee10fe4833f733b8c7abd878/llvm/lib/Transforms/InstCombine/InstCombineAndOrXor.cpp#L1616C28-L1616C28); however it is missing in current implementation of hotspot. This pull request adds this transformation and associated tests.
>>
>> Thanks.
>
> Zhiqiang Zang has updated the pull request incrementally with one additional commit since the last revision:
>
> move make_not back to AddNode because it cannot compile for architecture arm, s390x, ppc64le.
LGTM, thanks for the work! 😊
-------------
Marked as reviewed by epeter (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/16333#pullrequestreview-1811202862
More information about the hotspot-compiler-dev
mailing list