RFR: 8282365: Consolidate and improve division by constant idealizations [v42]

[Stefan Karlsson]

On Tue, 9 Jan 2024 15:29:44 GMT, Quan Anh Mai <qamai at openjdk.org> wrote:

>> In the Oracle-internal discussion of include order from about a year ago, there was not a consensus
>> decision about the position of "unittest.hpp".  There was a concern that in some cases it really was
>> required to be last for some technical reason.  That needed (and still needs) investigation.
>
> I assume this means that the include order is good as it is now?

Please update it to:

#include "precompiled.hpp"
#include "opto/divconstants.hpp"
#include "runtime/os.hpp"
#include "utilities/growableArray.hpp"
#include "unittest.hpp"

#include <type_traits>

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/9947#discussion_r1446279651