RFR: 8323115: x86-32: Incorrect predicates for cmov instruct transforms with UseSSE [v2]

Kim Barrett kbarrett at openjdk.org
Tue Jan 9 22:36:50 UTC 2024


> Please review this change that fixes generation of CMOV by C2 as controlled by
> UseSSE.  The predicates controlling that generation were using implicit
> operator precedence that didn't have the expected grouping.  Fixed by adding
> parentheses to make the desired grouping explicit.
> 
> Testing: Ran GHA with -Wparentheses enabled along with this and other changes
> needed to make that work.

Kim Barrett has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision:

 - Merge branch 'master' into x86-32-cmov-preds
 - fix predicates for cmov with UseSSE

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/17296/files
  - new: https://git.openjdk.org/jdk/pull/17296/files/f2c5ba0d..6f49985d

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=17296&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=17296&range=00-01

  Stats: 13013 lines in 180 files changed: 10072 ins; 1583 del; 1358 mod
  Patch: https://git.openjdk.org/jdk/pull/17296.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/17296/head:pull/17296

PR: https://git.openjdk.org/jdk/pull/17296


More information about the hotspot-compiler-dev mailing list