Integrated: 8322816: RISC-V: Incorrect guarantee in patch_vtype

Kim Barrett kbarrett at openjdk.org
Wed Jan 10 00:21:30 UTC 2024


On Tue, 2 Jan 2024 07:23:56 GMT, Kim Barrett <kbarrett at openjdk.org> wrote:

> Please review this change that fixes a test for a guarantee.  This also
> removes a -Wparentheses warning when those are enabled (which is how the
> problem was discovered).
> 
> The problem is that operator precedence groups the sub-expressions differently
> than intended. The fix is to override the operator precedence by adding
> parentheses to achieve the intended grouping.
> 
> Testing: Local (linux-x64) cross-build for linux-riscv with this change plus
> -Wparentheses enabled and other changes to allow that to work.
> 
> Requesting someone from the riscv porters to properly test this.

This pull request has now been integrated.

Changeset: f4ca41ad
Author:    Kim Barrett <kbarrett at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/f4ca41ad75fa78a08ff069ba0b6ac3596e35c23d
Stats:     5 lines in 1 file changed: 0 ins; 2 del; 3 mod

8322816: RISC-V: Incorrect guarantee in patch_vtype

Reviewed-by: fyang, luhenry

-------------

PR: https://git.openjdk.org/jdk/pull/17215


More information about the hotspot-compiler-dev mailing list