RFR: 8322077: Add Ideal transformation: (~a) | (~b) => ~(a & b) [v4]
Emanuel Peter
epeter at openjdk.org
Wed Jan 10 07:50:26 UTC 2024
On Sat, 6 Jan 2024 00:44:19 GMT, Zhiqiang Zang <duke at openjdk.org> wrote:
>> Looks like a good idea. Left a few comments.
>>
>> I would have merged this with https://github.com/openjdk/jdk/pull/16333, since it is essentially the symmetric case. But leave it separate now.
>>
>> It would be nice to have some shared tests, where both optimizations need to be combined. Like:
>> `(~a | ~b) & (~c | ~d)` -> `~(a & b) & ~(c & d)` -> `~((a & b) | (c & d))`
>
> @eme64 @TobiHartmann Thanks for the comments. All addressed.
>
> I rebased this PR onto #16333 so I was able to add these tests for using both optimizations. (the history was messed up).
@CptGit can you merge from master again, please? It looks now like you are pushing both the changes here and the ones from your previous PR. Once you did that, I'd like to run some testing before we push this.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/16334#issuecomment-1884342502
More information about the hotspot-compiler-dev
mailing list