RFR: 8290965: PPC64: Implement post-call NOPs [v2]

Richard Reingruber rrich at openjdk.org
Wed Jan 10 15:17:30 UTC 2024


On Wed, 27 Dec 2023 17:34:11 GMT, Martin Doerr <mdoerr at openjdk.org> wrote:

>> Richard Reingruber has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fix comment
>>   
>>   Co-authored-by: Andrew Haley <aph-open at littlepinkcloud.com>
>
> src/hotspot/cpu/ppc/macroAssembler_ppc.cpp line 1191:
> 
>> 1189:   }
>> 1190:   // We use CMPI/CMPLI instructions to encode post call nops.
>> 1191:   // We set bit 9 to distinguish post call nops from real CMPI/CMPI instructions
> 
> Should be CMPI/CMPLI. Maybe add that CMPI and CMPLI opcodes only differ in one bit which we use to encode data.

Done.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17171#discussion_r1447525235


More information about the hotspot-compiler-dev mailing list