RFR: JDK-8323190: Segfault during deoptimization of C2-compiled code [v2]

[Cesar Soares Lucas]

On Wed, 10 Jan 2024 08:57:58 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:

>> Cesar Soares Lucas has updated the pull request incrementally with three additional commits since the last revision:
>> 
>>  - Update test/hotspot/jtreg/compiler/escapeAnalysis/TestInvalidLocation.java
>>    
>>    Co-authored-by: Tobias Hartmann <tobias.hartmann at oracle.com>
>>  - Update src/hotspot/share/opto/output.cpp
>>    
>>    Co-authored-by: Tobias Hartmann <tobias.hartmann at oracle.com>
>>  - Update test/hotspot/jtreg/compiler/escapeAnalysis/TestInvalidLocation.java
>>    
>>    Co-authored-by: Tobias Hartmann <tobias.hartmann at oracle.com>
>
> src/hotspot/share/opto/output.cpp line 1092:
> 
>> 1090:         ObjectMergeValue* mv = (ObjectMergeValue*) sv_for_node_id(objs, smerge->_idx);
>> 1091: 
>> 1092:         if (mv == NULL) {
> 
> You should replace `NULL` with `nullptr` here and below. This also seems wrong here where you took the code from:
> https://github.com/openjdk/jdk/blob/88378ed0584c7eb0849b6fc1e361fd8ea0698caf/src/hotspot/share/opto/output.cpp#L775-L796
> 
> On a separate note, the code looks almost identical. Could it be shared somehow?

Thank you for reviewing @chhagedorn. I've converted the NULLs to nullptrs. However, I'll defer the refactoring of the identical code to a RFE - mainly because I'll have to backport the current patch and I'd like to keep it as minimal as possible. Please let me know if you disagree.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17333#discussion_r1447752271