RFR: JDK-8323190: Segfault during deoptimization of C2-compiled code [v3]
Tobias Hartmann
thartmann at openjdk.org
Thu Jan 11 08:30:25 UTC 2024
On Wed, 10 Jan 2024 18:16:42 GMT, Cesar Soares Lucas <cslucas at openjdk.org> wrote:
> I think AllocationMergesTests.java isn't the ideal place for these tests. The tests in AllocationMergesTests.java are for checking the IR shape after the optimization, the current issue was actually because of a problem emitting debug info for a compilation unit - it's not something that we can capture with the IR-framework I believe
Right, what I meant is that this issue shows that we don't have enough test coverage for all the cases optimized by [JDK-8287061](https://bugs.openjdk.org/browse/JDK-8287061). Or do we have an existing test for reduced allocation merges that are used as monitors? Ideally, we would have an IR framework test for the important cases that would then check both that the code is optimized as expected as well as that it's correct (no crash, correct result, ...).
I'm fine with adding more tests with https://github.com/openjdk/jdk/pull/15825 though.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/17333#issuecomment-1886607265
More information about the hotspot-compiler-dev
mailing list