RFR: 8323584: AArch64: Unnecessary ResourceMark in NativeCall::set_destination_mt_safe
Andrew Haley
aph at openjdk.org
Fri Jan 12 08:52:23 UTC 2024
On Thu, 11 Jan 2024 12:17:21 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:
> Was looking at `ICBuffer` cleaning paths that run at safepoint. In `NativeCall::set_destination_mt_safe`, there is a `ResourceMark` that does not seem to have any purpose: no code in its scope uses resource allocation. There is adjacent dead code too. Looks like a development/debugging leftover.
>
> Additional testing:
> - [ ] Linux x86_64 AArch64 server fastdebug, `tier{1,2,3}`
There are more of those. While they don't have much of an effect on runtime, it might be worth a cleanup pass to remove them in one go.
-------------
Marked as reviewed by aph (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/17372#pullrequestreview-1817683863
More information about the hotspot-compiler-dev
mailing list