RFR: 8322996: BoxLockNode creation fails with assert(reg < CHUNK_SIZE) failed: sanity [v3]

[Daniel Lundén]

On Thu, 11 Jan 2024 20:05:26 GMT, Vladimir Kozlov <kvn at openjdk.org> wrote:

>> Daniel Lundén has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Remove superfluous -TieredCompilation
>
> src/hotspot/share/opto/locknode.hpp line 66:
> 
>> 64:     return (int)reg < (int)(RegMask::CHUNK_SIZE - 1 - Compile::current()->sync_stack_slots());
>> 65:   }
>> 66: 
> 
> I think it should be in `regmask.hpp` together with other `can_represent_*` methods. Then you don't need part of the comment about those methods.

Thanks @vnkozlov. Do you know if we can directly use `can_represent` instead, and not take `sync_stack_slots()` into account? The field `_inmask` in `BoxLockNode` seems to only specify a single register (one bit in the mask).

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17370#discussion_r1450578513