RFR: 8323616: [JVMCI] TestInvalidJVMCIOption.java fails intermittently with NPE [v2]

Doug Simon dnsimon at openjdk.org
Tue Jan 16 08:24:32 UTC 2024


> This PR removes an assertion from `TestInvalidJVMCIOption` that can fail intermittently due to a race between JIT initialization and runtime class initialization.
> The only thing the test should guarantee is that an invalid option is detected and results in a VM exit.

Doug Simon has updated the pull request incrementally with two additional commits since the last revision:

 - do not call System.exit from libjvmci before module system is initialized
 - Revert "remove racy (and unnecessary) assertion in TestInvalidJVMCIOption"
   
   This reverts commit 5de1dcea6fc8926b6e17b6f12ef17f527fa8a007.

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/17397/files
  - new: https://git.openjdk.org/jdk/pull/17397/files/5de1dcea..0b183260

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=17397&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=17397&range=00-01

  Stats: 8 lines in 2 files changed: 8 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/jdk/pull/17397.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/17397/head:pull/17397

PR: https://git.openjdk.org/jdk/pull/17397


More information about the hotspot-compiler-dev mailing list