RFR: 8323616: [JVMCI] TestInvalidJVMCIOption.java fails intermittently with NPE [v4]

Tom Rodriguez never at openjdk.org
Tue Jan 16 15:57:21 UTC 2024


On Tue, 16 Jan 2024 12:28:31 GMT, Doug Simon <dnsimon at openjdk.org> wrote:

>> This PR changes callSystemExit to call `vm_exit_during_initialization()` instead of `System.exit` if the module system has not been initialized. This avoids an NPE in the `System.exit` code path where it is assumed that the `Class.module` field is non-null for `java.lang.Shutdown`.
>
> Doug Simon has updated the pull request incrementally with one additional commit since the last revision:
> 
>   use substring instead of equality test for expected error message

Looks good.

-------------

Marked as reviewed by never (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/17397#pullrequestreview-1823889605


More information about the hotspot-compiler-dev mailing list