RFR: 8323820: [MacOS] build failure: non-void function does not return a value

[Aleksey Shipilev]

On Tue, 16 Jan 2024 17:48:49 GMT, Joshua Cao <duke at openjdk.org> wrote:

> I can't reproduce the issue since I don't have the right build setup. But hopefully this change is trivial enough to fix the error.

Using older clang, maybe? These methods should have been marked `noreturn`, but there is a special block for older clang:
https://github.com/openjdk/jdk/blob/1007618f6f97fad0f66e4074b50521bdd853629e/src/hotspot/share/utilities/attributeNoreturn.hpp#L36-L48

src/hotspot/share/opto/castnode.cpp line 470:

> 468:     return new CastPPNode(c, in, type, dependency, types);
> 469:   }
> 470:   ShouldNotReachHere();

Keep the `fatal` with the message, and just add `return`?

-------------

PR Review: https://git.openjdk.org/jdk/pull/17449#pullrequestreview-1824492468
PR Review Comment: https://git.openjdk.org/jdk/pull/17449#discussion_r1453793559