RFR: 8320237 C2: late inlining of method handle invoke causes duplicate lines in PrintInlining output [v2]

[Kangcheng Xu]

On Tue, 16 Jan 2024 16:21:18 GMT, Tobias Hartmann <thartmann at openjdk.org> wrote:

>> Kangcheng Xu has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   fix VM crashes
>
> Thanks for the explanation. `compiler/inlining/TestDuplicatedLateInliningOutput.java` still failed once with `-XX:+UseZGC -XX:+ZGenerational`:
> 
> java.lang.Exception: No inlining found
> 	at compiler.inlining.TestDuplicatedLateInliningOutput.lambda$test$1(TestDuplicatedLateInliningOutput.java:77)
> 	at java.base/java.util.OptionalInt.orElseThrow(OptionalInt.java:273)
> 	at compiler.inlining.TestDuplicatedLateInliningOutput.test(TestDuplicatedLateInliningOutput.java:77)
> 	at compiler.inlining.TestDuplicatedLateInliningOutput.main(TestDuplicatedLateInliningOutput.java:46)
> 	at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
> 	at java.base/java.lang.reflect.Method.invoke(Method.java:580)
> 	at com.sun.javatest.regtest.agent.MainActionHelper$AgentVMRunnable.run(MainActionHelper.java:333)
> 	at java.base/java.lang.Thread.run(Thread.java:1575)

Hi @TobiHartmann,

Thank you for testing, but I've been unsuccessful in reproducing this error so far. Could you please elaborate on which config and the platform you were testing against? Also, am I correct to assume you were passing zgc options to the test harness (e.g., something like `make ... JTREG="VM_OPTIONS=-XX:+UseZGC -XX:+ZGenerational"`), not the actual subprocesses outputing those inlining log? (I did test running subprocesses with zgc options with no failures.) Either way, please advice how you were specifying zgc options.

Sorry if I'm missing something obvious here. I'm new to JDK development. :)

-------------

PR Comment: https://git.openjdk.org/jdk/pull/17147#issuecomment-1896424463