RFR: JDK-8322572: AllocationMergesTests.java fails with "IRViolationException: There were one or multiple IR rule failures."

[Vladimir Kozlov]

On Wed, 17 Jan 2024 21:41:49 GMT, Cesar Soares Lucas <cslucas at openjdk.org> wrote:

> Please review this PR to fix a test in `AllocationMergesTest.java`. The test was failing intermittently because of a random value used as parameter was causing some randomization in the shape method's IR graph and consequently the optimization tested wasn't happening.
> 
> Tested this locally on Mac, Win and Linux x86_64.

Add second (2024) year to Copyright line.

test/hotspot/jtreg/compiler/c2/irTests/scalarReplacement/AllocationMergesTests.java line 124:

> 122:         Asserts.assertEQ(testMergedAccessAfterCallNoWrite_Interp(cond1, x, y),      testMergedAccessAfterCallNoWrite_C2(cond1, x, y));
> 123:         Asserts.assertEQ(testCmpMergeWithNull_Second_Interp(cond1, x, y),           testCmpMergeWithNull_Second_C2(cond1, x, y));
> 124:         Asserts.assertEQ(testObjectIdentity_Interp(cond1, 42, y),                 testObjectIdentity_C2(cond1, 42, y));

Wrong spacing.

-------------

PR Review: https://git.openjdk.org/jdk/pull/17469#pullrequestreview-1828346047
PR Review Comment: https://git.openjdk.org/jdk/pull/17469#discussion_r1456582204