RFR: 8291809: Convert compiler/c2/cr7200264/TestSSE2IntVect.java to IR verification test [v2]

Emanuel Peter epeter at openjdk.org
Thu Jan 18 12:15:29 UTC 2024


On Thu, 18 Jan 2024 11:56:32 GMT, Emanuel Peter <epeter at openjdk.org> wrote:

>> Daniel Lundén has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Refactor test to use multiple @Test
>
> test/hotspot/jtreg/compiler/c2/cr7200264/TestIntVect.java line 643:
> 
>> 641:             a0[i] = (int)(a1[i]<<(-SHIFT));
>> 642:         }
>> 643:     }
> 
> Not sure why these don't vectorize. Need to investigate.

They are shifted by 32 bit, so maybe that creates something odd?

> test/hotspot/jtreg/compiler/c2/cr7200264/TestIntVect.java line 732:
> 
>> 730:     }
>> 731: 
>> 732:     void test_pack2(long[] p2, int[] a1) {
> 
> Intersting pattern! But that would require optimizations we currently do not have.
> Maybe we can do that in the future, with heavy upgrades to the autovectorizer,
> or other optimizations that merge loads / stores.

applies to all pack/swap cases here

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17428#discussion_r1457339577
PR Review Comment: https://git.openjdk.org/jdk/pull/17428#discussion_r1457345036


More information about the hotspot-compiler-dev mailing list