RFR: 8291809: Convert compiler/c2/cr7200264/TestSSE2IntVect.java to IR verification test [v2]
Daniel Lundén
dlunden at openjdk.org
Thu Jan 18 12:42:17 UTC 2024
On Thu, 18 Jan 2024 11:48:02 GMT, Emanuel Peter <epeter at openjdk.org> wrote:
>> Daniel Lundén has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Refactor test to use multiple @Test
>
> test/hotspot/jtreg/compiler/c2/cr7200264/TestIntVect.java line 406:
>
>> 404: if (errn > 0) {
>> 405: System.err.println("FAILED: " + errn + " errors");
>> 406: System.exit(97);
>
> Why not just throw an exception, with that error message?
Same comment here as for Christian's earlier comment: I do not touch the testing/verification code as part of this changeset (I only translate the previous ad-hoc IR checks to the IR framework).
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/17428#discussion_r1457382161
More information about the hotspot-compiler-dev
mailing list