RFR: 8291809: Convert compiler/c2/cr7200264/TestSSE2IntVect.java to IR verification test [v2]

Christian Hagedorn chagedorn at openjdk.org
Thu Jan 18 13:26:12 UTC 2024


On Thu, 18 Jan 2024 12:37:24 GMT, Daniel Lundén <dlunden at openjdk.org> wrote:

>> test/hotspot/jtreg/compiler/c2/cr7200264/TestIntVect.java line 406:
>> 
>>> 404:         if (errn > 0) {
>>> 405:             System.err.println("FAILED: " + errn + " errors");
>>> 406:             System.exit(97);
>> 
>> Why not just throw an exception, with that error message?
>
> Same comment here as for Christian's earlier comment: I do not touch the testing/verification code as part of this changeset (I only translate the previous ad-hoc IR checks to the IR framework).

I generally agree with that but `System.exit(97)` seems quite odd. Maybe you want to change that to throw an exception instead.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17428#discussion_r1457434059


More information about the hotspot-compiler-dev mailing list