RFR: 8315066: Add unsigned bounds and known bits to TypeInt/Long [v5]

Emanuel Peter epeter at openjdk.org
Fri Jan 19 15:14:29 UTC 2024


On Thu, 11 Jan 2024 03:20:29 GMT, Quan Anh Mai <qamai at openjdk.org> wrote:

>> Quan Anh Mai has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 27 commits:
>> 
>>  - Merge branch 'master' into improvevalue
>>  - Merge branch 'master' into improvevalue
>>  - improve add/sub implementation
>>  - Merge branch 'master' into improvevalue
>>  - typo
>>  - whitespace
>>  - fix tests for x86_32
>>  - fix widen of ConvI2L
>>  - problem lists
>>  - format
>>  - ... and 17 more: https://git.openjdk.org/jdk/compare/f0169341...843ad076
>
> May someone give their opinion on this PR, please? Thanks a lot.

@merykitty I've been seeing this PR for a while. I can't promise high priority here, but this looks interesting. It is also a scarily big changeset 😅 

A first remark: I would love to see more tests. For example: have some expressions that have certain bits random, and others masked on or off. Then you can have all sorts of ifs with bit checks, that lead to some special if-else code patterns. With an IR rule you can then see if this if gets folded, by checking if the true-block and/or false-block are still present.

What do you think?

-------------

PR Comment: https://git.openjdk.org/jdk/pull/15440#issuecomment-1900599235


More information about the hotspot-compiler-dev mailing list