RFR: 8315066: Add unsigned bounds and known bits to TypeInt/Long [v5]
Quan Anh Mai
qamai at openjdk.org
Fri Jan 19 20:10:27 UTC 2024
On Fri, 19 Jan 2024 15:11:24 GMT, Emanuel Peter <epeter at openjdk.org> wrote:
>> May someone give their opinion on this PR, please? Thanks a lot.
>
> @merykitty I've been seeing this PR for a while. I can't promise high priority here, but this looks interesting. It is also a scarily big changeset 😅
>
> A first remark: I would love to see more tests. For example: have some expressions that have certain bits random, and others masked on or off. Then you can have all sorts of ifs with bit checks, that lead to some special if-else code patterns. With an IR rule you can then see if this if gets folded, by checking if the true-block and/or false-block are still present.
>
> What do you think?
@eme64
> It is also a scarily big changeset 😅
Yes, it definitely is. If this is deemed a good idea then I would probably split it into patches which deal with different nodes and submit them separately. What do you think?
-------------
PR Comment: https://git.openjdk.org/jdk/pull/15440#issuecomment-1901037716
More information about the hotspot-compiler-dev
mailing list