RFR: 8324213: C1: There is no need for Canonicalizer to handle IfOp [v2]
Denghui Dong
ddong at openjdk.org
Fri Jan 19 23:37:37 UTC 2024
On Fri, 19 Jan 2024 21:39:08 GMT, Dean Long <dlong at openjdk.org> wrote:
>> Denghui Dong has updated the pull request incrementally with one additional commit since the last revision:
>>
>> update
>
> src/hotspot/share/c1/c1_Canonicalizer.cpp line 472:
>
>> 470:
>> 471: void Canonicalizer::do_IfOp(IfOp* x) {
>> 472: }
>
> If you are saying this method can never be called, then shouldn't we make it report an error instead of being empty?
Make sense.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/17499#discussion_r1460002161
More information about the hotspot-compiler-dev
mailing list