RFR: 8322743: assert(held_monitor_count() == jni_monitor_count()) failed [v2]
Vladimir Kozlov
kvn at openjdk.org
Sat Jan 20 01:57:28 UTC 2024
On Wed, 17 Jan 2024 20:20:05 GMT, Vladimir Kozlov <kvn at openjdk.org> wrote:
>> Corner case with a local (not escaped) object used for synchronization. C2 Escape Analysis thinks that it can eliminate locks for it. In most cases it is true but not in this case.
>>
>>
>> for (int i = 0; i < 2; ++i) {
>> Object o = new Object();
>> synchronized (o) { // monitorenter
>> // Trigger OSR compilation
>> for (int j = 0; j < 100_000; ++j) {
>>
>> The test has nested loop which trigger OSR compilation. The locked object comes from Interpreter into compiled OSR code. During parsing C2 creates an other non escaped object and correctly merge both together (with Phi node) so that non escaped object is not scalar replaceable. Because it does not globally escapes EA still removes locks for it and, as result, also for merged locked object from Interpreter which is the bug.
>>
>> The fix is to check that synchronized block does not have any associated escaped objects when EA decides if locks can be eliminated.
>>
>> Added regression test prepared by @TobiHartmann. Tested tier1-5, xcomp and stress.
>> Performance testing show no difference.
>
> Vladimir Kozlov has updated the pull request incrementally with one additional commit since the last revision:
>
> Address review comments
I agree, this is very interesting suggestion (for separate RFE) which may allow us to avoid inverted (and irreducible) loops and not just current locking issue.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/17331#issuecomment-1901583508
More information about the hotspot-compiler-dev
mailing list