RFR: 8324123: aarch64: fix prfm literal encoding in assembler [v2]

Wang Zhuo wzhuo at openjdk.org
Mon Jan 22 08:11:28 UTC 2024


On Fri, 19 Jan 2024 08:55:42 GMT, Andrew Haley <aph at openjdk.org> wrote:

>> Wang Zhuo has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   do not use inline for prfm encoding function
>
> src/hotspot/cpu/aarch64/assembler_aarch64.hpp line 1585:
> 
>> 1583:       int64_t offset = (adr.target() - pc()) >> 2;              \
>> 1584:       sf(offset, 23, 5);                                        \
>> 1585:     } else {                                                    \
> 
> This looks reasonable, but we don't need it to be inline. See the examples of `adr` and `_adrp`.

Thank you APH. I have updated the patch to make prfm no inline. Please check the commit 
do not use inline for prfm encoding function

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17482#discussion_r1461473867


More information about the hotspot-compiler-dev mailing list