RFR: 8323220: Reassociate loop invariants involved in Cmps and Add/Subs [v3]

[Emanuel Peter]

On Tue, 16 Jan 2024 17:30:34 GMT, Emanuel Peter <epeter at openjdk.org> wrote:

>> Joshua Cao has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Assert for n2. Variables for n1/n2 opcode. More concise comments.
>>   Overflow/random tests
>
> src/hotspot/share/opto/loopTransform.cpp line 333:
> 
>> 331: // inv1 == (inv2 - x) => (-inv1 + inv2 ) == x
>> 332: //
>> 333: Node* IdealLoopTree::reassociate_add_sub_cmp(Node* n1, int inv1_idx, int inv2_idx, PhaseIdealLoop *phase) {
> 
> Suggestion:
> 
> Node* IdealLoopTree::reassociate_add_sub_cmp(Node* n1, int inv1_idx, int inv2_idx, PhaseIdealLoop* phase) {

You should still do this change

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17375#discussion_r1461528935