RFR: JDK-8210858: AArch64: remove Math.log intrinsic [v2]

[Tobias Holenstein]

On Mon, 22 Jan 2024 09:53:08 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

>> Tobias Holenstein has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   remove MacroAssembler::fast_log() and generate_dlog()
>
> src/hotspot/cpu/aarch64/c1_LIRGenerator_aarch64.cpp line 834:
> 
>> 832:       break;
>> 833:     case vmIntrinsics::_dlog:
>> 834:       assert(StubRoutines::dlog() == nullptr, "no Math.log intrinsic on AArch64");
> 
> Is there a reason to assert this? I think the comment should be enough. And it could be richer as well, something like: 
> 
> 
>  // Math.log intrinsic is not implemented on AArch64 (see JDK-8210858),
>  // but we can still call the shared runtime.

Right, a comment makes more sense here than an assert! done.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17480#discussion_r1461830337