RFR: 8324123: aarch64: fix prfm literal encoding in assembler [v2]

Wang Zhuo wzhuo at openjdk.org
Tue Jan 23 03:41:27 UTC 2024


On Mon, 22 Jan 2024 10:25:38 GMT, Andrew Haley <aph at openjdk.org> wrote:

>> Wang Zhuo has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   do not use inline for prfm encoding function
>
> src/hotspot/cpu/aarch64/assembler_aarch64.cpp line 190:
> 
>> 188:   }
>> 189: 
>> 190: void Assembler::prfm(const Address &adr, prfop pfop) {
> 
> Suggestion:
> 
> // This encoding is similar (but not quite identical) to the encoding used
> // by literal ld/st. see JDK-8324123.
> void Assembler::prfm(const Address &adr, prfop pfop) {

Thanks for your suggestions. I have added the comments, please check

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17482#discussion_r1462687942


More information about the hotspot-compiler-dev mailing list