RFR: 8322996: BoxLockNode creation fails with assert(reg < CHUNK_SIZE) failed: sanity [v4]

Daniel Lundén dlunden at openjdk.org
Tue Jan 23 10:14:00 UTC 2024


> This changeset fixes an issue where deeply nested synchronized statements triggered an assert in C2.
> 
> Changes:
> - Bail out on compilation when we create a `BoxLockNode` with a slot index that cannot fit in a `RegMask`. This is similar to how we handle the case when we do not have space to represent arguments in [`opto/matcher.cpp`](https://github.com/openjdk/jdk/blob/58b01dce054c50bcb5a28aad4c1b574acaa90f6d/src/hotspot/share/opto/matcher.cpp#L314-L318)
> - Generalize `RegMask::can_represent` to take an additional and optional size argument to facilitate reuse. The default size value, 1, corresponds to the previous functionality. Rewrite `can_represent_arg` to directly call `can_represent(reg, SlotsPerVecZ)`.
> - Add a regression test.
> 
> Testing:
> - [GitHub Actions](https://github.com/dlunde/jdk/actions/runs/7612890820)
> - tier1 to tier5 on windows-x64, linux-x64, linux-aarch64, macosx-x64, and macosx-aarch64.
> - The new regression test in all tier1 to tier10 contexts on windows-x64, linux-x64, linux-aarch64, macosx-x64, and macosx-aarch64.

Daniel Lundén has updated the pull request incrementally with two additional commits since the last revision:

 - Update missed copyright
 - Refactor

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/17370/files
  - new: https://git.openjdk.org/jdk/pull/17370/files/9ab6e561..bf87138f

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=17370&range=03
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=17370&range=02-03

  Stats: 17 lines in 3 files changed: 1 ins; 8 del; 8 mod
  Patch: https://git.openjdk.org/jdk/pull/17370.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/17370/head:pull/17370

PR: https://git.openjdk.org/jdk/pull/17370


More information about the hotspot-compiler-dev mailing list