RFR: 8324433: Introduce a way to determine if an expression is evaluated as a constant by the Jit compiler [v5]
Quan Anh Mai
qamai at openjdk.org
Tue Jan 23 22:44:28 UTC 2024
On Tue, 23 Jan 2024 17:40:52 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:
>> Quan Anh Mai has updated the pull request incrementally with one additional commit since the last revision:
>>
>> ident
>
> src/java.base/share/classes/jdk/internal/misc/JitCompiler.java line 119:
>
>> 117: * @see #isCompileConstant(boolean)
>> 118: */
>> 119: @IntrinsicCandidate
>
> Note how the Java entry for MH intrinsic we have replaced had `@Hidden`. These methods should have `@Hidden` too then? Probably applies to other entries too.
I don't understand why this needs to be `@Hidden`, the javadoc says that a function annotated with `@Hidden` is omitted from the stacktraces. This function does not call anything so what is the point of hiding it?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/17527#discussion_r1464081953
More information about the hotspot-compiler-dev
mailing list