RFR: 8322996: BoxLockNode creation fails with assert(reg < CHUNK_SIZE) failed: sanity [v4]

Daniel Lundén dlunden at openjdk.org
Wed Jan 24 09:53:27 UTC 2024


On Wed, 24 Jan 2024 09:36:28 GMT, Roberto Castañeda Lozano <rcastanedalo at openjdk.org> wrote:

> The fix itself looks good to me. Would it make sense, for better coverage, to add a couple of additional test cases that exercise the boundaries of the condition that is tested? E.g. one with one `synchronized` statement less than the current one and one with one `synchronized` statement more.

I have experimented with such test cases (various edge cases) and as a result found a related (but separate) issue from this one. I was planning to add these additional tests for that separate issue, to not introduce unnecessary test failures before that fix is integrated. Maybe it is better to add the additional tests directly as part of this changeset instead?

-------------

PR Comment: https://git.openjdk.org/jdk/pull/17370#issuecomment-1907776710


More information about the hotspot-compiler-dev mailing list