RFR: 8291809: Convert compiler/c2/cr7200264/TestSSE2IntVect.java to IR verification test [v4]
Daniel Lundén
dlunden at openjdk.org
Wed Jan 24 13:05:51 UTC 2024
> This changeset translates the tests in `compiler/c2/cr7200264/` to use the IR verification framework.
>
> The proposed translation, to the extent possible, attempts to preserve the semantics of the original test. A major difference is that the IR checks are now local (for every `test_*` method) instead of global. The execution time of the new test is comparable to the old test.
>
> Testing:
> - [GitHub Actions](https://github.com/dlunde/jdk/actions/runs/7553846710)
> - Ran the new translated tests within all tier1 through tier10 contexts on windows-x64, linux-x64, linux-aarch64, macosx-x64, and macosx-aarch64.
> - Tested that manually adding `-XX:LoopUnrollLimit=0` to the test framework flags caused the translated tests to fail. Note: it is, however, no longer possible to break the test by passing `-XX:LoopUnrollLimit=0` on the command line.
Daniel Lundén has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 11 additional commits since the last revision:
- Updates after reviews
- Merge remote-tracking branch 'upstream/master' into test-sse2-int-vect-8291809-tmp
- Apply suggestions from code review
Co-authored-by: Emanuel Peter <emanuel.peter at oracle.com>
- Refactor test to use multiple @Test
- Remove TestDriver
- Readd verification
- Finalize changes
- Use static initialization block
- Experiments
- Naive translation complete
- ... and 1 more: https://git.openjdk.org/jdk/compare/cbebc6cd...1e4e74f0
-------------
Changes:
- all: https://git.openjdk.org/jdk/pull/17428/files
- new: https://git.openjdk.org/jdk/pull/17428/files/87715718..1e4e74f0
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jdk&pr=17428&range=03
- incr: https://webrevs.openjdk.org/?repo=jdk&pr=17428&range=02-03
Stats: 7545 lines in 265 files changed: 4574 ins; 1735 del; 1236 mod
Patch: https://git.openjdk.org/jdk/pull/17428.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/17428/head:pull/17428
PR: https://git.openjdk.org/jdk/pull/17428
More information about the hotspot-compiler-dev
mailing list