RFR: 8282365: Consolidate and improve division by constant idealizations [v33]

[Quan Anh Mai]

On Mon, 30 Oct 2023 15:38:52 GMT, Raffaello Giulietti <rgiulietti at openjdk.org> wrote:

>> Quan Anh Mai has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 74 commits:
>> 
>>  - fix proof
>>  - Merge branch 'master' into unsignedDiv
>>  - fix assert macro, benchmarks
>>  - comment styles
>>  - disable test with Xcomp
>>  - remove verify
>>  - fix x86 test
>>  - more rigorous control
>>  - verify the effectiveness of test
>>  - require x64
>>  - ... and 64 more: https://git.openjdk.org/jdk/compare/5224e979...529bd0f9
>
> I agree this is not necessarily optimal, but it's far easier to prove and to code.
> 
> There's a tradeoff here between simplicity of the proofs and of the code on one side, and squeezing out the last sub-nanosecond on the other side.
> Hard choice!

@rgiulietti Thanks very much for your reviews
@vnkozlov @eme64 Could you do another round of reviews, please? There has not been much change, though.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/9947#issuecomment-1910035550