RFR: 8322174: RISC-V: C2 VectorizedHashCode RVV Version [v2]
Yuri Gaevsky
duke at openjdk.org
Thu Jan 25 14:47:50 UTC 2024
On Wed, 17 Jan 2024 07:28:48 GMT, Fei Yang <fyang at openjdk.org> wrote:
>> Yuri Gaevsky has updated the pull request incrementally with two additional commits since the last revision:
>>
>> - num_8b_elems_in_vec --> nof_vec_elems
>> - Removed checks for (MaxVectorSize >= 16) per @RealFYang suggestion.
>
> src/hotspot/cpu/riscv/riscv_v.ad line 2681:
>
>> 2679: iRegLNoSp tmp4, iRegLNoSp tmp5, iRegLNoSp tmp6, rFlagsReg cr)
>> 2680: %{
>> 2681: predicate(UseRVV && (MaxVectorSize >= 16));
>
> Similar here: `MaxVectorSize >= 16` condition is already checked and ensured on JVM startup.
Fixed.
> src/hotspot/cpu/riscv/stubGenerator_riscv.cpp line 5266:
>
>> 5264: }
>> 5265:
>> 5266: if (UseVectorizedHashCodeIntrinsic && UseRVV && (MaxVectorSize >= 16)) {
>
> I think `MaxVectorSize >= 16` condition is already checked and ensured on JVM startup when RVV extension is available.
Fixed.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/17413#discussion_r1466480812
PR Review Comment: https://git.openjdk.org/jdk/pull/17413#discussion_r1466480645
More information about the hotspot-compiler-dev
mailing list