RFR: 8291809: Convert compiler/c2/cr7200264/TestSSE2IntVect.java to IR verification test [v2]
Daniel Lundén
dlunden at openjdk.org
Thu Jan 25 15:38:38 UTC 2024
On Thu, 25 Jan 2024 14:34:27 GMT, Emanuel Peter <epeter at openjdk.org> wrote:
>> Thanks @eme64. I've addressed all comments now; please have a look again.
>
> @dlunde Given the findings here: https://github.com/openjdk/jdk/pull/17428#discussion_r1466460916
> I think you should add a IR rule on every test.
> And for the ones that do not currently vectorize, please add a negative IR rule, so that we can detect when that changes.
> For example when we implement a feature, then we can properly fix up the IR rule.
@eme64
> @dlunde Given the findings here: [#17428 (comment)](https://github.com/openjdk/jdk/pull/17428#discussion_r1466460916) I think you should add a IR rule on every test.
I don't quite understand, what IR rule do you want me to add for every test? I'll of course add what we discussed for the problematic `test_divc` and `test_divc_n`.
> And for the ones that do not currently vectorize, please add a negative IR rule, so that we can detect when that changes. For example when we implement a feature, then we can properly fix up the IR rule.
Sure, I'll add negative rules for tests that do not currently vectorize (at all).
-------------
PR Comment: https://git.openjdk.org/jdk/pull/17428#issuecomment-1910452632
More information about the hotspot-compiler-dev
mailing list