RFR: 8324765: C2 SuperWord: remove dead code: SuperWord::insert_extracts

[Christian Hagedorn]

On Fri, 26 Jan 2024 15:14:13 GMT, Emanuel Peter <epeter at openjdk.org> wrote:

> Subtask of https://github.com/openjdk/jdk/pull/16620
> 
> As far as all tests and code study have showed me, SuperWord::insert_extracts is dead.
> 
> I am replacing it with verification code, that checks that no ExtractNode is required.
> 
> **Details**
> 
> All the relevant cases are marked as "unprofitable" in `SuperWord::profitable`, see:
> https://github.com/openjdk/jdk/blob/dfdd2174d7af5e3e995147484db17b45b006f6d0/src/hotspot/share/opto/superword.cpp#L1912-L1915

Looks good!

src/hotspot/share/opto/superword.cpp line 2854:

> 2852: #ifdef ASSERT
> 2853: // We check that every packset (name it p_def) only has vector uses (p_use),
> 2854: // which are properly vector uses of def.

Suggestion:

// which are proper vector uses of def.

-------------

Marked as reviewed by chagedorn (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/17589#pullrequestreview-1846495504
PR Review Comment: https://git.openjdk.org/jdk/pull/17589#discussion_r1468113205