RFR: 8324630: C1: Canonicalizer::do_LookupSwitch doesn't break the loop when the successor is found [v3]

Denghui Dong ddong at openjdk.org
Sat Jan 27 03:23:35 UTC 2024


On Sat, 27 Jan 2024 02:28:13 GMT, Dean Long <dlong at openjdk.org> wrote:

>> Denghui Dong has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   binary search
>
> src/hotspot/share/c1/c1_Canonicalizer.cpp line 848:
> 
>> 846:     int high = x->length() - 1;
>> 847:     while (low <= high) {
>> 848:       int mid = low + ((high - low) >> 1);
> 
> Isn't this the same as
> `int mid = (low + high) >> 1;`

`low + ((high - low) >> 1)`  can avoid integer overflow

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17553#discussion_r1468292902


More information about the hotspot-compiler-dev mailing list