RFR: 8317572: C2 SuperWord: refactor/improve TraceSuperWord, replace VectorizeDebugOption with TraceAutoVectorization [v5]

Emanuel Peter epeter at openjdk.org
Sat Jan 27 05:42:37 UTC 2024


On Fri, 26 Jan 2024 19:02:16 GMT, Vladimir Kozlov <kvn at openjdk.org> wrote:

>> Emanuel Peter has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   fix a test
>
> src/hotspot/share/compiler/compilerOracle.cpp line 779:
> 
>> 777:         }
>> 778:       }
>> 779: #ifndef PRODUCT
> 
> Missing `#ifdef COMPILER2` for this and `PrintIdealPhase`.

done!

> src/hotspot/share/compiler/directivesParser.cpp line 339:
> 
>> 337:             error(VALUE_ERROR, "Unrecognized intrinsic detected in DisableIntrinsic: %s", validator.what());
>> 338:           }
>> 339:         } else if (strncmp(option_key->name, "TraceAutoVectorization", 22) == 0) {
> 
> Missing `#ifndef PRODUCT` and `#ifdef COMPILER2` for this and for `PrintIdealPhase`.

done

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17586#discussion_r1468353324
PR Review Comment: https://git.openjdk.org/jdk/pull/17586#discussion_r1468353329


More information about the hotspot-compiler-dev mailing list