RFR: 8324794: C2 SuperWord: do not ignore reductions in SuperWord::unrolling_analysis

Vladimir Kozlov kvn at openjdk.org
Sat Jan 27 20:39:36 UTC 2024


On Sat, 27 Jan 2024 06:12:40 GMT, Emanuel Peter <epeter at openjdk.org> wrote:

> Subtask of https://github.com/openjdk/jdk/pull/16620
> 
> Ignoring reductions in unrolling_analysis is unnecessary, and it adds unnecessary dependency of unrolling_analysis on reduction-analysis. That dependency needs to be removed for further refactoring.

Change match the subject but your description is confusing:

> Ignoring reductions in unrolling_analysis is unnecessary, and it adds unnecessary dependency of unrolling_analysis on reduction-analysis. That dependency needs to be removed for further refactoring.

The only dependency you are talking about is the 'is_marked_reduction()` call in the condition you are removing. Right?

Do you know why this check was added?

-------------

PR Comment: https://git.openjdk.org/jdk/pull/17604#issuecomment-1913329053


More information about the hotspot-compiler-dev mailing list