RFR: JDK-8322648: Improve class initialization barrier in TemplateTable::_new for PPC [v2]

Varada M varadam at openjdk.org
Mon Jan 29 06:52:27 UTC 2024


On Mon, 29 Jan 2024 06:35:38 GMT, Martin Doerr <mdoerr at openjdk.org> wrote:

>> Varada M has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   8322648: Improve class initialization barrier in TemplateTable::_new for PPC
>
> src/hotspot/cpu/ppc/templateTable_ppc_64.cpp line 3808:
> 
>> 3806:     // Make sure klass is initialized.
>> 3807:     assert(VM_Version::supports_fast_class_init_checks(), "Optimization requires support for fast class initialization checks");
>> 3808:     __ clinit_barrier(Rcpool, R16_thread, nullptr /*L_fast_path*/, &Lslow_case);
> 
> `Rcpool` is the wrong parameter. You need to use `RinstanceKlass`.

Thank you for the correction @TheRealMDoerr . I have applied the code change. Tier1 test is running. I will push once it is done.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17518#discussion_r1469140673


More information about the hotspot-compiler-dev mailing list