RFR: 8322996: BoxLockNode creation fails with assert(reg < CHUNK_SIZE) failed: sanity [v4]

[Daniel Lundén]

On Wed, 24 Jan 2024 13:55:56 GMT, Roberto Castañeda Lozano <rcastanedalo at openjdk.org> wrote:

>>> The fix itself looks good to me. Would it make sense, for better coverage, to add a couple of additional test cases that exercise the boundaries of the condition that is tested? E.g. one with one `synchronized` statement less than the current one and one with one `synchronized` statement more.
>> 
>> I have experimented with such test cases (various edge cases) and as a result found a related (but separate) issue from this one. I was planning to add these additional tests for that separate issue, to not introduce unnecessary test failures before that fix is integrated. Maybe it is better to add the additional tests directly as part of this changeset instead?
>
>> I have experimented with such test cases (various edge cases) and as a result found a related (but separate) issue from this one. I was planning to add these additional tests for that separate issue, to not introduce unnecessary test failures before that fix is integrated. Maybe it is better to add the additional tests directly as part of this changeset instead?
> 
> If the additional tests trigger failures after this fix is applied, I would suggest including them as part of the fix to the separate issue.

Thanks @robcasloz and @vnkozlov. I've now rerun tests and the PR is ready for integration. Please sponsor!

-------------

PR Comment: https://git.openjdk.org/jdk/pull/17370#issuecomment-1914254957