Integrated: 8324236: compiler/ciReplay/TestInliningProtectionDomain.java failed with RuntimeException: should only dump inline information for ... expected true, was false

[Christian Hagedorn]

On Fri, 26 Jan 2024 21:42:27 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:

> The test failed when trying to match the compile id of the interesting method by looking for "`<nmethod compile_id='2`" in this line:
> 
> <nmethod compile_id='2' compiler='c2' entry='0x000000010e293f40' size='680' address='0x000000010e293d90' relocation_offset='360' insts_offset='432' stub_offset='568' scopes_data_offset='616' scopes_pcs_offset='624' dependencies_offset='672' oops_offset='600' metadata_offset='608' method='compiler.ciReplay.ProtectionDomainTestNoOtherCompilationPrivateString test ()V' bytes='5' count='6784' iicount='6784' stamp='0.307'/>
> 
> But it first found the earlier line:
> 
> <nmethod compile_id='20' compile_kind='c2n' compiler='' entry='0x000000010e28b6c0' size='544' address='0x000000010e28b510' relocation_offset='360' insts_offset='432' method='java.lang.invoke.MethodHandle linkToStatic (ILjava/lang/invoke/MemberName;)Ljava/lang/Object;' bytes='0' count='0' iicount='0' stamp='0.213'/>
> 
>  which unfortunately also matched "`<nmethod compile_id='2`". I suggest to make the check stronger by adding a closing `'` which should then only match "`<nmethod compile_id='2'`"
> 
> Thanks,
> Christian

This pull request has now been integrated.

Changeset: 72ba8178
Author:    Christian Hagedorn <chagedorn at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/72ba8178a8271d4a04a0b789f28b23414b8989ed
Stats:     1 line in 1 file changed: 0 ins; 0 del; 1 mod

8324236: compiler/ciReplay/TestInliningProtectionDomain.java failed with RuntimeException: should only dump inline information for ... expected true, was false

Reviewed-by: kvn

-------------

PR: https://git.openjdk.org/jdk/pull/17598